Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for insertion markers wrapping blocks mid stack #6898

Open
1 task done
BeksOmega opened this issue Mar 15, 2023 · 0 comments
Open
1 task done

Add support for insertion markers wrapping blocks mid stack #6898

BeksOmega opened this issue Mar 15, 2023 · 0 comments
Labels
component: insertion marker issue: feature request Describes a new feature and why it should be added low priority

Comments

@BeksOmega
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

Scratch's insertion markers will wrap blocks mid stack:

ddd008ab-cd13-4b8b-ae21-97a16cec7982

However this is not supported in core blockly:
38bd759f-301d-4e7e-871e-c31cf749daff

Because it requires monkey patching the connection: connect and doDragChecks which now lives in the connection checker. It also requires patching the insertion marker manager. See this discussion for more info: #6876 (comment)

Request

Add support for insertion markers wrapping blocks mid stack.

No clue what APIs we would need to actually implement this though. I think the first patch is especially complicated, because it lives in the connection code and is incompatible with the current behavior.

Alternatives considered

N/A

Additional context

Linking the original discussion that surfaced this issue again: #6876 (comment)

@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Mar 15, 2023
@rachel-fenichel rachel-fenichel added low priority component: insertion marker and removed issue: triage Issues awaiting triage by a Blockly team member labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: insertion marker issue: feature request Describes a new feature and why it should be added low priority
Projects
None yet
Development

No branches or pull requests

2 participants