Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't replace shadow blocks in statement inputs #6938

Closed
1 task done
maribethb opened this issue Mar 30, 2023 · 1 comment · Fixed by #6939
Closed
1 task done

Can't replace shadow blocks in statement inputs #6938

maribethb opened this issue Mar 30, 2023 · 1 comment · Fixed by #6939
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@maribethb
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

Shadow blocks connected to statement inputs can't be replaced. When dragging a new block, there is no insertion marker and the blocks are not connected when you release the drag. If there is no shadow block, things work fine.

Shadow blocks work fine when connected to value inputs.

Note this is new in 9.3.0

Related: https://groups.google.com/g/blockly/c/r3Jw5uhHvuc

Reproduction steps

  1. Open the Code demo
  2. Paste the following into the JSON tab
  3. Try to drag a new print block into the statement connection, observe no connection is made
{
  "blocks": {
    "languageVersion": 0,
    "blocks": [
      {
        "type": "controls_repeat_ext",
        "id": "K[j){YWz}cgy~}L]bY~!",
        "x": 237,
        "y": 138,
        "inputs": {
          "TIMES": {
            "shadow": {
              "type": "math_number",
              "id": "Y@%oW+58GnOknRlkKsUi",
              "fields": {
                "NUM": 10
              }
            }
          },
          "DO": {
            "shadow": {
              "type": "text_print",
              "id": "lk}*,J0qTdg@8Eu7767Y",
              "inputs": {
                "TEXT": {
                  "shadow": {
                    "type": "text",
                    "id": "9UPY%/4+oy{*T#dxp_D`",
                    "fields": {
                      "TEXT": "abc"
                    }
                  }
                }
              }
            }
          }
        }
      },
      {
        "type": "text_print",
        "id": "Wx=@]t{O2#[xcgC%n6kl",
        "x": 363,
        "y": 287,
        "inputs": {
          "TEXT": {
            "shadow": {
              "type": "text",
              "id": "RgRfIE##~8SO?kV7!BRP",
              "fields": {
                "TEXT": "abc"
              }
            }
          }
        }
      }
    ]
  }
}

Stack trace

No errors or messages.

Screenshots

No response

Browsers

No response

@maribethb maribethb added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Mar 30, 2023
@maribethb
Copy link
Contributor Author

Update: We are working on fixing this issue and will release a patch. The root cause is #6800

@cpcallen cpcallen removed the issue: triage Issues awaiting triage by a Blockly team member label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants