Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JSON deserialization use the render queue #7290

Closed
1 task done
BeksOmega opened this issue Jul 14, 2023 · 0 comments · Fixed by #7306
Closed
1 task done

Make JSON deserialization use the render queue #7290

BeksOmega opened this issue Jul 14, 2023 · 0 comments · Fixed by #7306
Assignees
@BeksOmega
Labels
issue: feature request Describes a new feature and why it should be added

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Jul 14, 2023 •
edited
Loading

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

JSON Deserialization currently still uses the old immediate rendering system, because I haven't had time to clean it up yet.

Request

Instead it should use the render queue, so we can fully tear out the old system.

Alternatives considered

N/A

Additional context

I think I can get away with not updating XML by using the same immediate-render function suggested in #7068 (comment), but I'll know more once I dig into this!
@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Jul 14, 2023
@BeksOmega BeksOmega changed the title Make deserialization use the render queue Make JSON deserialization use the render queue Jul 14, 2023
@BeksOmega BeksOmega self-assigned this Jul 14, 2023
@BeksOmega BeksOmega mentioned this issue Jul 19, 2023
Merged
4 tasks
@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeksOmega BeksOmega

Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make deserialization use the new render management system BeksOmega/blockly
2 participants
@maribethb @BeksOmega