Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addClass and removeClass methods to the block to deal with CSS classes #8270

Closed
BeksOmega opened this issue Jul 10, 2024 · 4 comments
Closed
Assignees
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Milestone

Comments

@BeksOmega
Copy link
Collaborator

To Fix

  1. Add an addClass method to the BlockSvg class, that takes in a passed string, and calls dom.addClass with the this.svgGroup_ to add it as a CSS class on the block.
  2. Add a removeClass method to the BlockSvg class, that takes in a passed string, and calls dom.removeClassClass with the this.svgGroup_.
  3. Refactor any calls in the BlockSvg class to dom.addClass with this.svgGroup_ to call this.addClass instead.
  4. Refactor any calls in the BlockSvg class to dom.removeClass with this.svgGroup_ to call this.removeClass instead.

The PR to fix this should be made against the rc/v12.0.0 branch.

To work on this issue, please comment below asking to be assigned.

@BeksOmega BeksOmega added help wanted External contributions actively solicited PR: feature Adds a feature good first issue labels Jul 10, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 10, 2024
@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added and removed PR: feature Adds a feature labels Jul 10, 2024
@ishon19
Copy link

ishon19 commented Jul 11, 2024

Hi @BeksOmega! I'd love to work on this and the dependent issue #8271 as well, can you please assign me to both of these whenever you get time? Thanks!

@BeksOmega
Copy link
Collaborator Author

Heya @ishon19 Happily =) But you have to comment on #8271 for me to assign you :/ (this is a restriction with the GitHub UI)

@ishon19
Copy link

ishon19 commented Jul 11, 2024

Heya @ishon19 Happily =) But you have to comment on #8271 for me to assign you :/ (this is a restriction with the GitHub UI)

My bad! No problem, adding a comment over there.

@BeksOmega
Copy link
Collaborator Author

Closed by #8337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

No branches or pull requests

2 participants