Use of javax.lang.model.SourceVersion not flagged by AndroidJdkLibsChecker

[msridhar]

See here: mozilla/rhino#1149 (comment)

I see that javax.lang.model.type.TypeKind is explicitly banned:

error-prone/core/src/main/java/com/google/errorprone/bugpatterns/apidiff/AndroidJdkLibsChecker.java

Lines 211 to 213 in 959d405

	private static final ImmutableSet<String> BASE_BANNED_CLASSES =
	// see b/72354470, https://github.com/typetools/checker-framework/issues/1781
	ImmutableSet.of("javax/lang/model/type/TypeKind");

Shouldn't everything under javax.lang be flagged?

[msridhar]

@cushon just curious, does f8185d1 fix this issue?

[cushon]

Sorry, I don't think it will, f8185d1 should be a no-op for check behaviour, it's just moving the computation of the APIs to check to happen statically instead of every time the check runs

[cushon]

Also I think that banning everything under javax.lang makes sense, although I need to do some more testing to confirm that wouldn't cause any issues with our existing uses of this check

[p-bakker]

Any update on this?