New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in minisite_url #7078

Closed

rsheeter opened this issue Dec 7, 2023 · 1 comment · Fixed by #7079

Labels

I API / Website / Platform I Request I Tools / workflow / repo

Collaborator

rsheeter commented Dec 7, 2023

$ find . -name METADATA.pb -exec grep -H  minsite_url {} \;
./ofl/unbounded/METADATA.pb:minsite_url: "https://unbounded.polkadot.network/"
./ofl/jetbrainsmono/METADATA.pb:minsite_url: "https://www.jetbrains.com/lp/mono/"
./ofl/bonanova/METADATA.pb:minsite_url: "http://bonanova.wtf/"

I thought CI would catch this?

rsheeter added I Tools / workflow / repo I API / Website / Platform I Request labels

Collaborator

m4rc1e commented Dec 7, 2023

Eugh, this comes from #7074. Our CI did flag this.

Screenshot 2023-12-07 at 22 32 07

chrissimpkins mentioned this issue

Fix typos in minisite_url metadata fields #7079

Merged

vv-monsalve closed this as completed in #7079

felipesanches mentioned this issue

Add a FATAL check status fonttools/fontbakery#4374

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment