Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth grant_type=password is inaccessible #629

Closed
jonjohnsonjr opened this issue Dec 10, 2019 · 5 comments · May be fixed by #1740
Closed

Oauth grant_type=password is inaccessible #629

jonjohnsonjr opened this issue Dec 10, 2019 · 5 comments · May be fixed by #1740

Comments

@jonjohnsonjr
Copy link
Collaborator

jonjohnsonjr commented Dec 10, 2019

Before #628 we would fall back to the oauth flow for username/password if the token flow failed. This is not great behavior, since it almost always will fail, so we removed that fallback. As a result, there's actually no way to use username/password with the oauth flow.

Docker has a similar codepath that is reachable if the ForceOAuth option is set in their TokenHandlerOptions, but as far as I can tell there's no existing code that actually exercises that path in the docker client.

It's unclear to me if any registries support this or any clients need it, and there's no easy way to tell if we should take that path from the registry response.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@splucs
Copy link

splucs commented Jun 21, 2023

/reopen

@splucs
Copy link

splucs commented Jun 21, 2023

/remove-lifecycle stale

@splucs
Copy link

splucs commented Aug 23, 2023

@jonjohnsonjr friendly ping on the PR for this: #1740

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants