Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect basic auth credentials return 404 instead of 401 against gcr #669

Closed
thisisnotashwin opened this issue Feb 4, 2020 · 2 comments
Closed

Incorrect basic auth credentials return 404 instead of 401 against gcr #669

thisisnotashwin opened this issue Feb 4, 2020 · 2 comments

Comments

@thisisnotashwin
Copy link

thisisnotashwin commented Feb 4, 2020 •
edited
Loading

A change made to the file /pkg/v1/remote/transport/bearer.go as a part of #566 leads to the refresh() method attempting to refresh the oauth token if basic auth returns an unauthorized error. While this behavior does make sense, if the credentials passed in were basic auth credentials, the attempt to refresh the oauth token return the following error from gcr with a confusing error message and a status code of 404 which is misleading given it should have been a 401 error.

<html lang=en>
  <meta charset=utf-8>
  <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
  <title>Error 404 (Not Found)!!1</title>
  <style>
    *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
  </style>
  <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
  <p><b>404.</b> <ins>That’s an error.</ins>
  <p>The requested URL <code>/v2/token</code> was not found on this server.  <ins>That’s all we know.</ins>

Is there a possibility that it could return the 401 error in case the the attempt to refresh the oauth token fails?
@jonjohnsonjr
Copy link
Collaborator

I think this was fixed in #628

@thisisnotashwin
Copy link
Author

You're right. Thanks for clearing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonjohnsonjr @thisisnotashwin