cbc.CMakeLists.txt should point to a version in or-tools releases

[moriarty]

in v6.10:

or-tools/cmake/external/cbc.CMakeLists.txt

Line 12 in 554cbcc

GIT_TAG "master"

the tag points to master

[moriarty]

This is almost a duplicate of #1167 and #1159 ...

The fix for #1159 e08d64c is still brittle because it points to the master branch, and anyone building a tagged version of or-tools who would expect the build to be the same won't always get the same result if changes are pushed to cbc master.

If or-tools is being build in a docker layer, for example:

ARG OR_TOOLS_RELEASE_TAG=v6.10

RUN git clone --branch ${OR_TOOLS_RELEASE_TAG} --single-branch --depth=1 \
      https://github.com/google/or-tools /var/local/git/or-tools && \
    cd /var/local/git/or-tools && \
    mkdir build && \
    cd build && \
    cmake .. && \
    make -j$(nproc) && \
    make install && \
    cd / && \
    rm -rf /var/local/git/or-tools

Then this is now broken.

[moriarty]

work around for now (diff of above Dockerfile):

 ARG OR_TOOLS_RELEASE_TAG=v6.10
 
+# We need a patch to fix an issue in an OR-Tools dependency:
+# https://github.com/google/or-tools/issues/1169
+
 RUN git clone --branch ${OR_TOOLS_RELEASE_TAG} --single-branch --depth=1 \
       https://github.com/google/or-tools /var/local/git/or-tools && \
     cd /var/local/git/or-tools && \
+    curl https://github.com/google/or-tools/commit/e08d64c370bb02af07b463ee951be74353e79e51.patch | git apply -v && \
     mkdir build && \
     cd build && \
     cmake .. && \

[Mizux]

the issue is not master branch vs commit sha1, it is because I have to reuse the repository name Cbc so I rename it coinor-cbc (which is archived and i won't expect to change its name)...

Previous way to build Cbc was based on the coinor svn archive where I added a full CMake support but it was based on this monolithic archive while you can see now on github (and in few distro) that coin or change their mine and provide it as separate repo (CoinUtils, Clp, Cbc ...).

I'm on my way to add CMake suppport for this splitted layout, you can follow the #1116 to follow this clean-up.

[moriarty]

@Mizux thanks for the explanation and link to 1116. 👍