Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIFuzz: repository can't be cloned as recursive #4780

Closed
athre0z opened this issue Dec 4, 2020 · 4 comments
Closed

CIFuzz: repository can't be cloned as recursive #4780

athre0z opened this issue Dec 4, 2020 · 4 comments
Assignees

Comments

@athre0z
Copy link
Contributor

athre0z commented Dec 4, 2020

We're currently in the progress of implementing CIFuzz for Zydis and stumbled across the issue that it doesn't appear to be possible to tell CIFuzz to clone a repo recursively. Since we depend on that to pull in our zycore utility library, CIFuzz currently doesn't work for us.

I can't pretend to understand all the inner workings of CIFuzz, but it appears to me like the non-recursive clone originates here:

out, _, _ = utils.execute(['git', 'clone', self.repo_url, self.repo_name],

Our workflow config can be viewed here: https://github.com/zyantific/zydis/blob/6b48854250013bad75f570d1b566e56f19770c4d/.github/workflows/main.yml#L43
A corresponding failed run: https://github.com/zyantific/zydis/runs/1498160477

Just cloning every repository recursively sounds risky, so that probably won't be the fix -- my suggestion would be to add a GH action config just like e.g. oss-fuzz-project-name: 'zydis' where users can specify recursive-clone: true.

It's also very much possible that we're just doing it wrong -- any help would be appreciated!

@jonathanmetzman
Copy link
Contributor

Hmm....I'm working on a new API for projects to use CIFuzz where you simply provide the repo to CIFuzz rather than CIFuzz cloning the repo for you. Do you want to try using this?

@jonathanmetzman jonathanmetzman self-assigned this Dec 7, 2020
@flobernd
Copy link

flobernd commented Dec 7, 2020

@jonathanmetzman Sure, that sounds great :-) Could you point us a site to get started?

@jonathanmetzman
Copy link
Contributor

Sorry for the big delay in this. I ended up changing the API so I think we still may have a problem here.
I'm still thinking about a solution to this.

@jonathanmetzman
Copy link
Contributor

Duplicate: #6755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants