fix: remove noise lockfile warnings #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 78.14% 77.93% -0.21%
==========================================
Files 81 81
Lines 5866 5825 -41
==========================================
- Hits 4584 4540 -44
- Misses 1082 1084 +2
- Partials 200 201 +1 ☔ View full report in Codecov by Sentry. |
cuixq
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're previously agreed that in these situations we should be erroring since the native package manager does not support them but cannot make that change until v2 as it's technical breaking.
In the meantime we've currently got tests that cover these situations but unlike panics we cannot suppress the warnings because of how Go works resulting in a very noisy time when any test fails; it's gotten to the point that I've decided to actually make this PR 😅
Since in theory these could actually still be useful especially for folks like Scorecard as part of helping confirm the parsers are handling edge-cases, I'm happy to alternatively gate these behind an env variable that is disabled by default but I don't have strong opinions on this.