From 8280873642b948427cccbafd037e19d2a23d46d9 Mon Sep 17 00:00:00 2001 From: Jess Lowe Date: Thu, 16 Jan 2025 02:34:30 +0000 Subject: [PATCH] Added support for underscores in headers --- deployment/terraform/modules/osv/osv_api.tf | 2 +- gcp/api/test_server.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/deployment/terraform/modules/osv/osv_api.tf b/deployment/terraform/modules/osv/osv_api.tf index 7a55604a1fb..d85c8c80a93 100644 --- a/deployment/terraform/modules/osv/osv_api.tf +++ b/deployment/terraform/modules/osv/osv_api.tf @@ -126,7 +126,7 @@ resource "google_cloud_run_service" "api" { image = data.google_container_registry_image.api.image_url env { name = "ESPv2_ARGS" - value = "^++^--transcoding_preserve_proto_field_names++--envoy_connection_buffer_limit_bytes=104857600" + value = "^++^--transcoding_preserve_proto_field_names++--envoy_connection_buffer_limit_bytes=104857600++--underscores_in_headers" } resources { limits = { diff --git a/gcp/api/test_server.py b/gcp/api/test_server.py index 01a6196e417..6076210c83c 100644 --- a/gcp/api/test_server.py +++ b/gcp/api/test_server.py @@ -106,6 +106,7 @@ def start_esp(port, backend_port, credential_path, log_path): '--disable_tracing', '--service=api-test.osv.dev', '--rollout_strategy=managed', + '--underscores_in_headers', f'--listener_port={port}', f'--backend=grpc://{host}:{backend_port}', '--enable_debug', @@ -134,6 +135,7 @@ def start_esp(port, backend_port, credential_path, log_path): '--disable_tracing', '--service=api-test.osv.dev', '--rollout_strategy=managed', + '--underscores_in_headers', f'--listener_port={port}', f'--backend=grpc://{host}:{backend_port}', f'--service_account_key=/esp/{credential_name}',