You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Another alternative would be to do manually triggered tests: if pprof is invoked with a special flag, it passes that to the javascript, and the javascript code when it sees that flag runs self tests. But it would be better to figure out how to have real tests.
The text was updated successfully, but these errors were encountered:
Should we leave this issue as open until we cover most of the Javascript code with tests (the current state just exercises one small part - the sorting of the Top table)?
Per @ghemawat from #790:
None of the javascript in pprof is tested.
One alternative is that we might need to install node in some github action and use that (maybe something like https://github.com/browser-actions/examples).
Another alternative would be to do manually triggered tests: if pprof is invoked with a special flag, it passes that to the javascript, and the javascript code when it sees that flag runs self tests. But it would be better to figure out how to have real tests.
The text was updated successfully, but these errors were encountered: