Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Bazel 7.3.1 (bzlmod) #51

Closed
wants to merge 11 commits into from
Closed

Update to Bazel 7.3.1 (bzlmod) #51

wants to merge 11 commits into from

Conversation

s0l0ist
Copy link

@s0l0ist s0l0ist commented Oct 14, 2024 •
edited
Loading

Updates the Bazel toolchain dependencies to their latest versions and migrates away from the previous Bazel WORKSPACE in favor of Bzlmod MODULE.bazel

Doesn't quite fix #46, because it's not published to the Bazel Central Registry, but you can import into other Bzlmod MODULES by doing something like:

# MODULE.bazel
http_archive(
    name = "private_join_and_compute",
    sha256 = "<sha>",
    strip_prefix = "private-join-and-compute-<commit_sha>",
    url = "https://github.com/google/private-join-and-compute/archive/<commit_sha>.zip",
)

Also fixes a .bazelrc duplicate declaration:

  • build --host_cxxopt='-std=c++17' -> test --host_cxxopt='-std=c++17'

I do not think the previous version had a working wheel or it may have been a WIP. This PR doesn't fix the python gaps, but it at least makes it conformant to the latest rules.

@google-cla Google CLA
Copy link

google-cla bot commented Oct 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@karnseth
Copy link
Collaborator

Hello, thank you for this wonderful change, we are planning to update the repo to use Bzlmod, and due to some technicalities of how we are exporting code, it is much easier for us to create a separate commitment. Would you mind if we used this PR as a reference? We can add a credit to you in the README

@s0l0ist
Copy link
Author

s0l0ist commented Dec 18, 2024 •
edited
Loading

@karnseth, sure that's fine! I'll be happy that I don't have to maintain my fork :)

@karnseth
Copy link
Collaborator

Committed at a00b422

Thank you!

@karnseth karnseth closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish private-join-and-compute as a Bazel module
2 participants
@s0l0ist @karnseth