Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs opportunity? - Did not work out of the box in VS Code without adding source set #561

Closed
mattwelke opened this issue Jun 1, 2022 · 4 comments
Labels
gradle compatibility Compatibility issues with Gradle

Comments

@mattwelke
Copy link

I use VS Code for most Java work. Usually things work out of the box whether I'm using Maven, Gradle, or no build tool at all. For this plugin, running the Gradle commands after setting up worked fine. It generated Java source code under build/... and my code code was able to reference this generated source code to complete a build. However, it only worked if I was running Gradle commands.

VS Code itself didn't work right. It didn't seem to be aware of the generated source code. If I tried to import it, VS Code displayed error messages (even though the Gradle build worked fine). Example:

image

I describe the issue in detail here: https://stackoverflow.com/questions/72440517/how-do-i-configure-vs-code-and-gradle-to-use-generated-java-code-with-the-gradle

Here's what I want to know... Is this the way the plugin is supposed to work? That it supports Gradle, and nothing else? And it's up to other tools to add config to detect the source code? If this is the case, perhaps the solution is to add documentation to the plugin repo's README file to describe to VS Code users how to make VS Code aware of the generated source code. Or, if this is not the way the plugin is supposed to work, should there be some change to how it works to make tools like VS Code detect the generated source code and add it to their class path automatically (if that's even possible)?

@mattwelke
Copy link
Author

Looks someone suggested a change that would fix this issue on the plugin side: #109 (comment)

@rougsig rougsig added the gradle compatibility Compatibility issues with Gradle label Jul 19, 2022
@ejona86
Copy link
Collaborator

ejona86 commented Sep 26, 2022

This should be resolved with #590. (#601 should have helped, but wasn't enough by itself.)

@ejona86 ejona86 closed this as completed Sep 26, 2022
@mattwelke
Copy link
Author

@ejona86 Cool. In order to test this, I'd want to keep an eye on releases for this repo to see when the PR you link to gets included in a release right? The fix wouldn't yet be in v0.8.19 (latest version right now)?

@ejona86
Copy link
Collaborator

ejona86 commented Sep 26, 2022

Right. It'll be in v0.9.0, which I would ordinarily hope is this week, but may not end up being so (due to other busyness).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gradle compatibility Compatibility issues with Gradle
Projects
None yet
Development

No branches or pull requests

3 participants