Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native controls not displaying #3121

Closed
michellezhuogg opened this issue Jan 27, 2021 · 1 comment
Closed

Native controls not displaying #3121

michellezhuogg opened this issue Jan 27, 2021 · 1 comment
Assignees
@ismena
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.1

Comments

@michellezhuogg
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v3.0.7

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Demo app

What browser and OS are you using?
Chrome on Mac OS

What are the manifest and license server URIs?
https://nightly-dot-shaka-player-demo.appspot.com/demo/#audiolang=es;textlang=es;uilang=en;asset=https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4;panel=ALL_CONTENT;panelData=HLS;build=uncompiled;nativecontrols

What did you do?
Disable the Shaka Control and start playback.

What did you expect to happen?
The control bar should show on mouse over.

What actually happened?
The control bar shows when the playback is starting, and cannot be displayed later.
@michellezhuogg michellezhuogg added the type: bug Something isn't working correctly label Jan 27, 2021
@shaka-bot shaka-bot added this to the v3.1 milestone Jan 27, 2021
@joeyparrish
Copy link
Member

I found that <div class="shaka-client-side-ad-container"> is blocking mouse events from getting to the native controls.

@joeyparrish joeyparrish added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs flag: good first issue This might be a relatively easy issue; good for new contributors component: UI The issue involves the Shaka Player UI labels Feb 12, 2021
@ismena ismena self-assigned this Feb 12, 2021
joeyparrish pushed a commit that referenced this issue Mar 11, 2021
@ismena @joeyparrish
fix(ads): Hide the ad container when ads aren't playing.
b1cdba7 
The ad container intervened with native browser controls in Chrome.

Closes #3121

Change-Id: I620d3318c8f9e5bed0a83c3de66f746d20c6703e
This was referenced Mar 16, 2021
Merged
Closed
Closed
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 4, 2021
@shaka-project shaka-project locked and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
4 participants
@ismena @joeyparrish @shaka-bot @michellezhuogg