From 28aff89443ab2f156dcb9f6a3bfb0f466f6b76ab Mon Sep 17 00:00:00 2001 From: Ville Aikas Date: Thu, 7 Jul 2022 09:29:48 -0700 Subject: [PATCH] Address PR feedback. Signed-off-by: Ville Aikas --- .../workflows/kind-scaffolding-e2e-createtree.yml | 4 ++-- .../scaffolding/log-server/placeholder.go | 15 --------------- 2 files changed, 2 insertions(+), 17 deletions(-) delete mode 100644 examples/deployment/kubernetes/scaffolding/log-server/placeholder.go diff --git a/.github/workflows/kind-scaffolding-e2e-createtree.yml b/.github/workflows/kind-scaffolding-e2e-createtree.yml index d1213bd1c5..5f8de11ef2 100644 --- a/.github/workflows/kind-scaffolding-e2e-createtree.yml +++ b/.github/workflows/kind-scaffolding-e2e-createtree.yml @@ -64,12 +64,12 @@ jobs: - name: Create a tree on it run: | echo '::group:: install create tree job' - ko apply -BRf ./examples/deployment/kubernetes/createtree + kubectl apply -Rf ./examples/deployment/kubernetes/createtree echo '::endgroup::' echo '::group:::' waiting for job to complete' kubectl wait -n createtree --for=condition=Complete --timeout=5m jobs createtree echo '::endgroup::' - kubectl -n createtree get cm trillian-tree -ojsonpath='{.data.treeID}' + kubectl -n createtree get cm trillian-tree -ojsonpath='{.data.treeID}' - name: Collect diagnostics if: ${{ failure() }} diff --git a/examples/deployment/kubernetes/scaffolding/log-server/placeholder.go b/examples/deployment/kubernetes/scaffolding/log-server/placeholder.go deleted file mode 100644 index 1474cc01c3..0000000000 --- a/examples/deployment/kubernetes/scaffolding/log-server/placeholder.go +++ /dev/null @@ -1,15 +0,0 @@ -// Copyright 2022 The Sigstore Authors -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package trillianlogserver