Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsx support? #156

Closed
hvent90 opened this issue May 15, 2018 · 2 comments
Closed

tsx support? #156

hvent90 opened this issue May 15, 2018 · 2 comments

Comments

@hvent90
Copy link

hvent90 commented May 15, 2018

Hi all,

Thanks for writing such a wonderful package.

npm run check returns the following error if a .tsx file is present:
Error parsing -style: Unsuitable

Update: Changing baseArgs to ['style', 'file'] in ./node_modules/gts/build/src/format.js (line 13) and moving .clang-format from ./node_modules/gts to ./node_modules/gts/build/src stopped the error from showing.

@ofrobots
Copy link
Contributor

Thanks for reporting the problem @hvent90. It seems like the default config expects all files meant to be input for the TypeScript compiler will be .ts files and runs clang-format on them with the JavaScript style – resulting in the error reported above. We'll look into a fix.

@ofrobots ofrobots added the bug label May 21, 2018
ofrobots added a commit to ofrobots/ts-style that referenced this issue Feb 5, 2019
BREAKING CHANGE: Switch to prettier as the code formatter.

Fixes: google#156
ofrobots added a commit that referenced this issue Feb 6, 2019
* feat!: switch to prettier for formatting

BREAKING CHANGE: Switch to prettier as the code formatter.

Fixes: #156
@ofrobots
Copy link
Contributor

ofrobots commented Feb 6, 2019

Fixed via #259.

@ofrobots ofrobots closed this as completed Feb 6, 2019
ofrobots added a commit that referenced this issue Feb 7, 2019
* feat!: switch to prettier for formatting

BREAKING CHANGE: Switch to prettier as the code formatter.

Fixes: #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants