Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CBS is empty after importing keys #60

Open
jonasfj opened this issue Nov 2, 2022 · 0 comments
Open

Ensure CBS is empty after importing keys #60

jonasfj opened this issue Nov 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@jonasfj
Copy link
Member

jonasfj commented Nov 2, 2022

Whenever we create a CBS object, it's usually because we're feeding some data into BoringCrypto. If all the data is not read, this usually indicates invalid data. If importing a key doesn't consume all the bytes supplied in the key, we should probably reject it.

This needs test cases to ensure compatibility with web implementations.

Look code referencingScope.createCBS those places probably have to check that CBS is empty after it's been processed.

This requires testing of invalid key bytes, so probably blocked by #55

@jonasfj jonasfj added the bug Something isn't working label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant