From 98d5284283f9eb2839c756ba4f338631f2744cd3 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 2 Oct 2024 13:42:41 -0700 Subject: [PATCH 1/2] address diagnostics and update to a more recent package:lints --- .github/workflows/ci.yaml | 4 ++-- CHANGELOG.md | 5 +++-- lib/src/common/utils.dart | 2 -- pubspec.yaml | 6 +++--- test/firefox_alert_test.dart | 2 ++ test/firefox_command_event.dart | 2 ++ test/firefox_cookies_test.dart | 2 ++ test/firefox_navigation_test.dart | 2 ++ test/firefox_target_locator_test.dart | 2 ++ test/firefox_timeouts_test.dart | 2 ++ test/firefox_w3c_basic_sync_test.dart | 2 ++ test/firefox_w3c_keyboard_test.dart | 2 ++ test/firefox_w3c_mouse_test.dart | 2 ++ test/firefox_web_driver_test.dart | 2 ++ test/firefox_web_element_test.dart | 2 ++ test/firefox_window_test.dart | 2 ++ 16 files changed, 32 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index df74f07..5fcba52 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -40,7 +40,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - sdk: [3.0.0, stable, dev] + sdk: [3.1, stable, dev] steps: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 @@ -66,7 +66,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - sdk: [3.0.0, stable, dev] + sdk: [3.1, stable, dev] steps: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 diff --git a/CHANGELOG.md b/CHANGELOG.md index c031d4f..b764290 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ -## 3.0.4-wip +## 3.0.4 -* Require Dart 3.0. +* Require Dart 3.1. +* Update to the latest package:lints. ## 3.0.3 diff --git a/lib/src/common/utils.dart b/lib/src/common/utils.dart index 0046085..27d856b 100644 --- a/lib/src/common/utils.dart +++ b/lib/src/common/utils.dart @@ -12,7 +12,5 @@ WebDriverHandler getHandler(WebDriverSpec spec) { return W3cWebDriverHandler(); case WebDriverSpec.Auto: return InferWebDriverHandler(); - default: - throw UnsupportedError('Unexpected web driver spec: $spec.'); } } diff --git a/pubspec.yaml b/pubspec.yaml index 66cab08..c79072f 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,12 +1,12 @@ name: webdriver -version: 3.0.4-wip +version: 3.0.4 description: >- Provides WebDriver bindings for Dart. Supports WebDriver JSON interface and W3C spec. Requires the use of WebDriver remote server. repository: https://github.com/google/webdriver.dart environment: - sdk: ^3.0.0 + sdk: ^3.1.0 dependencies: matcher: ^0.12.10 @@ -16,5 +16,5 @@ dependencies: dev_dependencies: archive: ^3.3.0 - lints: ^3.0.0 + lints: ^4.0.0 test: ^1.16.0 diff --git a/test/firefox_alert_test.dart b/test/firefox_alert_test.dart index 312b196..b070218 100644 --- a/test/firefox_alert_test.dart +++ b/test/firefox_alert_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_command_event.dart b/test/firefox_command_event.dart index e41fb44..c388d51 100644 --- a/test/firefox_command_event.dart +++ b/test/firefox_command_event.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_cookies_test.dart b/test/firefox_cookies_test.dart index a9bfcc9..c7587ab 100644 --- a/test/firefox_cookies_test.dart +++ b/test/firefox_cookies_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_navigation_test.dart b/test/firefox_navigation_test.dart index 34677a5..af1cd44 100644 --- a/test/firefox_navigation_test.dart +++ b/test/firefox_navigation_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_target_locator_test.dart b/test/firefox_target_locator_test.dart index 37dde4e..da5b3f7 100644 --- a/test/firefox_target_locator_test.dart +++ b/test/firefox_target_locator_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_timeouts_test.dart b/test/firefox_timeouts_test.dart index a86d475..2e49586 100644 --- a/test/firefox_timeouts_test.dart +++ b/test/firefox_timeouts_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_w3c_basic_sync_test.dart b/test/firefox_w3c_basic_sync_test.dart index 5546038..904710d 100644 --- a/test/firefox_w3c_basic_sync_test.dart +++ b/test/firefox_w3c_basic_sync_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_w3c_keyboard_test.dart b/test/firefox_w3c_keyboard_test.dart index cdb6f42..e1046d1 100644 --- a/test/firefox_w3c_keyboard_test.dart +++ b/test/firefox_w3c_keyboard_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_w3c_mouse_test.dart b/test/firefox_w3c_mouse_test.dart index d73164d..54c84a2 100644 --- a/test/firefox_w3c_mouse_test.dart +++ b/test/firefox_w3c_mouse_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_web_driver_test.dart b/test/firefox_web_driver_test.dart index fe36d6b..3573ed1 100644 --- a/test/firefox_web_driver_test.dart +++ b/test/firefox_web_driver_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_web_element_test.dart b/test/firefox_web_element_test.dart index 5a73c55..9551a39 100644 --- a/test/firefox_web_element_test.dart +++ b/test/firefox_web_element_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; diff --git a/test/firefox_window_test.dart b/test/firefox_window_test.dart index 517b858..64ed297 100644 --- a/test/firefox_window_test.dart +++ b/test/firefox_window_test.dart @@ -13,6 +13,8 @@ // limitations under the License. @Tags(['ff']) +library; + import 'package:test/test.dart'; import 'package:webdriver/sync_core.dart'; From beb18905fbebf48c30f8af30fc7e156853221d74 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 2 Oct 2024 13:50:38 -0700 Subject: [PATCH 2/2] Update CHANGELOG.md Co-authored-by: Kevin Moore --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b764290..76e34c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,6 @@ ## 3.0.4 * Require Dart 3.1. -* Update to the latest package:lints. ## 3.0.3