-
Notifications
You must be signed in to change notification settings - Fork 284
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Added type to content source (#680)
* Added type to content source Resolved an issue with IMA plugin and HLS plugin on post-roll completed ads: without the source type the player hangs with a format not supported error. * Update player-wrapper.js * Update player-wrapper.js
- Loading branch information
1 parent
0fbf8f5
commit d8cb13d
Showing
1 changed file
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8cb13d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I already mentioned in one of your PR, this functionality duplicates what contrib-ads already does. There is also bug (same as I reported in contrib-ads), when multiple sources are present. It restores only one source and loose others which breaks any plugin or functionality working with multiple sources (like quality selector, etc)