-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type to content source #680
Conversation
Resolved an issue with IMA plugin and HLS plugin on post-roll completed ads: without the source type the player hangs with a format not supported error.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
src/player-wrapper.js
Outdated
this.vjsPlayer.autoplay(false); | ||
this.vjsPlayer.src({ | ||
src: this.contentSource, | ||
type: this.contentSourceType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint says you're missing a trailing comma here - other than that, looks good to me!
src/player-wrapper.js
Outdated
@@ -461,6 +467,7 @@ PlayerWrapper.prototype.onAdError = function(adErrorEvent) { | |||
*/ | |||
PlayerWrapper.prototype.onAdBreakStart = function() { | |||
this.contentSource = this.vjsPlayer.currentSrc(); | |||
this.contentSourceType = this.player.currentType(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay here - I couldn't figure out why those tests are failing, and I finally found it - this needs to be this.vjsPlayer.currentType()
instead of this.player.currentType()
Resolved an issue with IMA plugin and HLS plugin on post-roll completed ads: without the source type the player hangs with a format not supported error.
Originally solved in old IMA plugin version by @valse:
#433