This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
fix: Stop Duplicate Response Handlers on Retries #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
danielbankhead
changed the title
danielbankhead
pushed a commit
to googleapis/nodejs-storage
that referenced
this pull request
Jan 26, 2022
danielbankhead
added a commit
to googleapis/nodejs-storage
that referenced
this pull request
Jan 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
startUploadingwould setup a 'response' event listener for passing responses toresponseHandler- this is problematic in the event of a retry as the retry would create its own request (thus previous requests would triggerresponseHandleras well).Instead, we can accomplish the desired functionality by checking
makeRequestStream's return value.Fixes #493 🦕