fix: prevent potential panic in RemoveStatementHint #253
+40
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RemoveStatementHint function converts the SQL string to upper case for simple checking for specific prefixes. This check did however not take into account that the length of a string in upper case can be different from the length in lower/mixed case. SQL strings with any of those characters in the relevant parts (hint or first keyword) are not valid, so in those cases the original SQL string is returned. Fixes #251
rahul2393
approved these changes
Jun 17, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.0](https://togithub.com/googleapis/go-sql-spanner/compare/v1.4.0...v1.5.0) (2024-07-01) ### Features * Add -race to testing ([#263](https://togithub.com/googleapis/go-sql-spanner/issues/263)) ([3af784b](https://togithub.com/googleapis/go-sql-spanner/commit/3af784b0a786c7079f14a63cbef5da4ad7ad3138)) * Add fuzzing for statement parser ([#250](https://togithub.com/googleapis/go-sql-spanner/issues/250)) ([2e74813](https://togithub.com/googleapis/go-sql-spanner/commit/2e7481307b02ec2deb98599e22362ee727d0fc1b)) * Add int support ([#260](https://togithub.com/googleapis/go-sql-spanner/issues/260)) ([ec15462](https://togithub.com/googleapis/go-sql-spanner/commit/ec1546238603f409a0aba6627459365c46a92c2b)), refs [#257](https://togithub.com/googleapis/go-sql-spanner/issues/257) * **examples/data-types:** Add float32 ([#261](https://togithub.com/googleapis/go-sql-spanner/issues/261)) ([4d6d1ef](https://togithub.com/googleapis/go-sql-spanner/commit/4d6d1ef0856cd6b964675cb64a3f4c7335e010dc)) ### Bug Fixes * []*int and []*uint ([#267](https://togithub.com/googleapis/go-sql-spanner/issues/267)) ([d24b55a](https://togithub.com/googleapis/go-sql-spanner/commit/d24b55ade2c4c4f5ce01d1f3fcbec41e6ad0d50c)) * **examples:** Make compilable and add a test runner for the samples ([#256](https://togithub.com/googleapis/go-sql-spanner/issues/256)) ([b9c0b4d](https://togithub.com/googleapis/go-sql-spanner/commit/b9c0b4d5e5fbfdb3bb358d9a54f66029855a0b2f)) * Prevent potential panic in RemoveStatementHint ([#253](https://togithub.com/googleapis/go-sql-spanner/issues/253)) ([7d7155b](https://togithub.com/googleapis/go-sql-spanner/commit/7d7155b2bbc430ed88420d8bf92abbb59638adb4)), refs [#251](https://togithub.com/googleapis/go-sql-spanner/issues/251) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RemoveStatementHint function converts the SQL string to upper case for simple checking for specific prefixes. This check did however not take into account that the length of a string in upper case can be different from the length in lower/mixed case. SQL strings with any of those characters in the relevant parts (hint or first keyword) are not valid, so in those cases the original SQL string is returned.
Fixes #251