feat: add isolation level option for disabling internal retries #327
+96
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal retries of aborted transactions is enabled by default for database/sql connections for Spanner. However, when an application or framework knows that it will retry the transaction using a retry-loop, it is more efficient to disable internal retries. Some frameworks, such as gorm, however make this hard to achieve, as they only allow TxOptions to be used to configure the transaction, and do not give access to the underlying driver or connection. This change adds a custom isolation level that can be used to disable internal retries of aborted transactions.
harshachinta
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal retries of aborted transactions is enabled by default for database/sql connections for Spanner. However, when an application or framework knows that it will retry the transaction using a retry-loop, it is more efficient to disable internal retries.
Some frameworks, such as gorm, however make this hard to achieve, as they only allow TxOptions to be used to configure the transaction, and do not give access to the underlying driver or connection.
This change adds a custom isolation level that can be used to disable internal retries of aborted transactions.