Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonar failers due to 401 #1591

Closed
zhumin8 opened this issue Dec 10, 2024 · 3 comments
Closed

sonar failers due to 401 #1591

zhumin8 opened this issue Dec 10, 2024 · 3 comments
Assignees

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Dec 10, 2024

all sonar builds has been failing since Dec2.
https://github.com/googleapis/google-auth-library-java/actions/runs/12131139021/job/33822744230

Error:  Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar (default-cli) on project google-auth-library-parent: Error status returned by url [https://api.sonarcloud.io/analysis/jres?os=linux&arch=x86_64]: 401 -> [Help 1]

similar issue in sdk-platform-java: googleapis/sdk-platform-java#3369

@meltsufin
Copy link
Member

Added SONAR_TOKEN and validated the workflow working in #1592.

@lqiu96
Copy link
Contributor

lqiu96 commented Dec 11, 2024

Re-opening this as it seems to still fail: https://github.com/googleapis/google-auth-library-java/actions/runs/12282128891/job/34272653159?pr=1590

Min mentioned above that this seems to be flaky in sdk-platform-java as well: googleapis/sdk-platform-java#3369

@lqiu96 lqiu96 reopened this Dec 11, 2024
@lqiu96
Copy link
Contributor

lqiu96 commented Jan 8, 2025

This is not a flaky issue, but rather an issue when PRs are raised from forks. Fork PRs do not have access to secrets and cannot use the SONAR_TOKEN secret.

We have disabled sonar from running when the PR comes from Forks. For now, the workaround way to test with sonar is when PRs come in from forks:

  1. Raise the PR to a branch
  2. Raise a PR from the branch in above step to main

"Fixed" in #1606

@lqiu96 lqiu96 closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants