-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement quota project from env var in google/auth #452
Conversation
reopened at the request of @sai-sunder-s |
It appears that if
|
I do not think setting quotaProject is required anywhere.
Removing it would definitely be breaking. Also we don't want to remove it. There is no "preferred", it's just that in some situations a user might want to use an env var, and in some situations a parameter.
In the case that both are set, the parameter is used. I'm all for adding clarity on this, and will add documentation to reflect this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
No description provided.