Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java-core): capturing startup logs and writing them to the logger incase end of stream reached #9108

Merged
merged 6 commits into from
Feb 14, 2023
Merged

fix(java-core): capturing startup logs and writing them to the logger incase end of stream reached #9108

merged 6 commits into from
Feb 14, 2023

Conversation

jainsahab
Copy link
Contributor

fixes #9097

@jainsahab jainsahab mentioned this pull request Feb 9, 2023
Closed
@suztomo
Copy link
Member

suztomo commented Feb 9, 2023 •
edited
Loading

Thank you for moving PR here.

Using local (snapshot) build, did you confirm this pull request fixes the “Playground” class execution written in the issue?
image

@jainsahab
Copy link
Contributor Author

Using local (snapshot) build, did you confirm this pull request fixes the “Playground” class execution written in the issue?

Hi @suztomo , Yes here it is.

image

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 9, 2023
@suztomo
Copy link
Member

suztomo commented Feb 9, 2023

lint is also failing.

@suztomo suztomo changed the title Capturing startup logs and writing them to the logger incase end of stream reached fix(java-core): capturing startup logs and writing them to the logger incase end of stream reached Feb 9, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 13, 2023
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2023
@jainsahab jainsahab merged commit def8637 into googleapis:main Feb 14, 2023
@release-please release-please bot mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlockingProcessStreamReader.java doesn't log the error text and silently exits
2 participants
@jainsahab @suztomo