Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recommender] Java SDK lacks recommendations.markDismissed API #9780

Closed
hbui-sc opened this issue Aug 23, 2023 · 1 comment
Closed

[Recommender] Java SDK lacks recommendations.markDismissed API #9780

hbui-sc opened this issue Aug 23, 2023 · 1 comment
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@hbui-sc
Copy link

hbui-sc commented Aug 23, 2023

  1. Specify the API: Java recommender
  2. OS type and version: MacOS 13.5
  3. Java version: 1.8
  4. Version(s): 1

Steps to reproduce

We cannot use the recommendations.markDismissed API which is in the service definition (https://cloud.google.com/recommender/docs/reference/rpc/google.cloud.recommender.v1#google.cloud.recommender.v1.Recommender.MarkRecommendationDismissed).

Java SDK only supports mark[Claimed|Failed|Succeeded] but lacks the markDismissed() API.

There are code samples for markClaimed/Failed/Succeeded. However, the recommender_service protobuf lacks of the methods for the markDismissed API.

Could we request to support markDismissed for recommendations?

@alicejli alicejli self-assigned this Aug 25, 2023
@blakeli0 blakeli0 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 25, 2023
@alicejli
Copy link
Contributor

This has been fixed with #9791. The next release will contain an updated library with this method (~2-3 weeks ish); if you need it sooner, please compile the library directly from the main branch of this repo (mvn compile && mvn package will generate a jar that you can use in the interim). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants