Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Record.fromZoneRecord_ doesn't handle multiple records correctly (MX) #2552

Closed
timwsuqld opened this issue Aug 22, 2017 · 1 comment
Closed
Assignees
Labels
api: dns Issues related to the Cloud DNS API.

Comments

@timwsuqld
Copy link

Environment details

  • OS: Linux
  • Node.js version: 4.2.6
  • npm version: 3.5.2
  • google-cloud-node version: 0.6.2

Steps to reproduce

When importing zone files (bind format) using zone.import, we call Record.fromZoneRecord_ on each line. However, when you have multiple of the same record that should in be a single result set (i.e. MX records), it actually creates a record set per line, which doesn't result in the correct zone being created.

The resourceRecordSets rrdatas should be a list (https://cloud.google.com/dns/api/v1/resourceRecordSets#resource) of all the records, not multiple resourceRecordSets. The result is only the last MX record is imported.

This would probably also cause problems if for example you have multiple TXT records, or multiple A records.

@stephenplusplus stephenplusplus added the api: dns Issues related to the Cloud DNS API. label Aug 22, 2017
@stephenplusplus
Copy link
Contributor

This issue was moved to googleapis/nodejs-dns#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API.
Projects
None yet
Development

No branches or pull requests

2 participants