Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to reenable quickstart tests on 3 libraries that need SA key credentials #3670

Closed
sofisl opened this issue Nov 18, 2022 · 0 comments · Fixed by #3803
Closed

Need to reenable quickstart tests on 3 libraries that need SA key credentials #3670

sofisl opened this issue Nov 18, 2022 · 0 comments · Fixed by #3803
Assignees
Labels
samples Issues that are directly related to samples.

Comments

@sofisl
Copy link
Contributor

sofisl commented Nov 18, 2022

These libraries need an actual SA key credential saved to the GOOGLE_CLOUD_APPLICATIONS_CREDENTIAL variable, but this is not supported with our current Cloud Build triggers. We need to create a new trigger that only runs for these select libraries and fills this env variable in with the value from a secret. These are the libraries that need sample tests reenabled:

[ ] #3600
[ ] #3564
[ ] #3562

@sofisl sofisl self-assigned this Nov 18, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 18, 2022
@sofisl sofisl changed the title Need to reenable sample tests on 3 libraries that need SA key credentials Need to reenable quickstart tests on 3 libraries that need SA key credentials Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant