Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing customVoice in dialogflow.VoiceSelectionParams #5903

Open
7 tasks done
orgads opened this issue Dec 24, 2024 · 2 comments
Open
7 tasks done

Missing customVoice in dialogflow.VoiceSelectionParams #5903

orgads opened this issue Dec 24, 2024 · 2 comments
Assignees

Comments

@orgads
Copy link
Contributor

orgads commented Dec 24, 2024

Please make sure you have searched for information in the following guides.

A screenshot that you have tested with "Try this API".

N/A

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://gist.github.com/orgads/9af03eaa5db52728955de168bdc014bc

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

Just try to build this file with Typescript, and it fails.

Object literal may only specify known properties, and 'customVoice' does not exist in type 'IVoiceSelectionParams'.ts(2353)

A clear and concise description of what the bug is, and what you expected to happen.

VoiceSelectionParams should contain customVoice, as it does in text-to-speech, documented here. This is missing in dialogflow, documented here.

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

It is supported in the private CCAI dialogflow library. IIRC this is the only notable change (at least for what we use) between the official and the private sdk.

@orgads orgads changed the title Missing customVoice in dialogflow.v2beta1.VoiceSelectionParams Missing customVoice in dialogflow.VoiceSelectionParams Dec 24, 2024
@sofisl
Copy link
Contributor

sofisl commented Jan 22, 2025

Hi @orgads, I see it in the protos now, could you give this a try again?

As an FYI, our REST API (the documentation you linked) isn't always the same as the version in this library - it actually corresponds to google-api-nodejs-client. They are independent, so there's no guarantee of parity or, if there is, not necessarily temporal parity. Sometimes it's just worth waiting a bit, and if you don't see it (and there aren't any PRs that need to be merged on the repo), it could be worth requesting it to the API itself in the issue tracker, since it means they haven't made that feature available in the grpc library.

@sofisl sofisl added the needs more info This issue needs more information from the customer to proceed. label Jan 22, 2025
@sofisl sofisl self-assigned this Jan 23, 2025
@orgads
Copy link
Contributor Author

orgads commented Jan 23, 2025

Where do you see it? The linked doc still doesn't have it, and the node client version 6.13.0 still misses it.

Is it possible to move the issue to the api project?

@github-actions github-actions bot removed the needs more info This issue needs more information from the customer to proceed. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants