From f0d424be6f34f58264d38c3dbe9966718af80ea2 Mon Sep 17 00:00:00 2001 From: Mattie Fu Date: Fri, 19 Aug 2022 13:25:51 -0400 Subject: [PATCH] address comments --- .../cloud/bigtable/data/v2/it/BuiltinMetricsIT.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BuiltinMetricsIT.java b/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BuiltinMetricsIT.java index b4a21e3084..f619f86f0a 100644 --- a/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BuiltinMetricsIT.java +++ b/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BuiltinMetricsIT.java @@ -15,8 +15,8 @@ */ package com.google.cloud.bigtable.data.v2.it; -import static com.google.common.truth.TruthJUnit.assume; import static com.google.common.truth.Truth.assertThat; +import static com.google.common.truth.TruthJUnit.assume; import com.google.api.client.util.Lists; import com.google.cloud.bigtable.data.v2.BigtableDataSettings; @@ -26,7 +26,6 @@ import com.google.cloud.bigtable.test_helpers.env.EmulatorEnv; import com.google.cloud.bigtable.test_helpers.env.TestEnvRule; import com.google.cloud.monitoring.v3.MetricServiceClient; -import com.google.cloud.monitoring.v3.MetricServiceSettings; import com.google.monitoring.v3.ListTimeSeriesRequest; import com.google.monitoring.v3.ListTimeSeriesResponse; import com.google.monitoring.v3.ProjectName; @@ -35,8 +34,6 @@ import java.io.IOException; import java.time.Duration; import java.util.ArrayList; -import java.util.concurrent.TimeUnit; - import org.junit.AfterClass; import org.junit.BeforeClass; import org.junit.ClassRule; @@ -68,12 +65,8 @@ public static void setUpClass() throws IOException { // Enable built in metrics BigtableDataSettings.enableBuiltinMetrics(); - MetricServiceSettings settings = - MetricServiceSettings.newBuilder() - .setEndpoint("staging-monitoring.sandbox.googleapis.com:443") - .build(); // Create a cloud monitoring client - metricClient = MetricServiceClient.create(settings); + metricClient = MetricServiceClient.create(); } @AfterClass @@ -103,7 +96,7 @@ public void testBuiltinMetrics() throws Exception { ProjectName name = ProjectName.of(testEnvRule.env().getProjectId()); // Restrict time to last 10 minutes - long startMillis = System.currentTimeMillis() - Duration.ofMinutes (10).toMillis(); + long startMillis = System.currentTimeMillis() - Duration.ofMinutes(10).toMillis(); TimeInterval interval = TimeInterval.newBuilder() .setStartTime(Timestamps.fromMillis(startMillis))