Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add admin APIs for AuthorizedView #2175

Merged
merged 6 commits into from
Mar 27, 2024
Merged

feat: Add admin APIs for AuthorizedView #2175

merged 6 commits into from
Mar 27, 2024

Conversation

trollyxia
Copy link
Member

Change-Id: Ie31eae6da61ed0d0462e029f6247924785b239bf

@trollyxia trollyxia requested review from a team as code owners March 19, 2024 19:27
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 19, 2024
feat: Add admin APIs for AuthorizedView
feb960c 
Change-Id: Ie31eae6da61ed0d0462e029f6247924785b239bf
chore: Mark AuthorizedViewType as InternalApi
e65fa69 
Change-Id: If52e3a32c3259f652f1f7d34b013d1ec1fc0a773
chore: Add tests and change AuthorizedViewType to InternalExtensionOnly
d37860e 
Change-Id: I2e7f04d0f7815d014928a924d4a4f26adb2b655d
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2024
@trollyxia trollyxia mentioned this pull request Mar 20, 2024
Merged
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2024
@mutianf mutianf removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 20, 2024
@trollyxia trollyxia requested a review from a team as a code owner March 20, 2024 23:37
@mutianf mutianf added do-not-merge do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do-not-merge labels Mar 21, 2024
igorbernstein2
igorbernstein2 requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I think the only thing that might be missing is to update the cleanupStale rule:

https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/TestEnvRule.java#L182

...ble/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAuthorizedViewRequest.java Outdated
return this;
}

/** Configures if safety warnings should be disabled. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. please expand what safety means here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@trollyxia
Copy link
Member Author

Looks pretty good. I think the only thing that might be missing is to update the cleanupStale rule:

https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/test_helpers/env/TestEnvRule.java#L182

I don't think we need to update that since when a table is deleted, all the authorized views inside that table are also cascading deleted.

Chore: fix a comment
023c67d 
Change-Id: Iac28b6cbef3088e4e2d43d90655155369361c347
mutianf
mutianf reviewed Mar 27, 2024
View reviewed changes
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/FamilySubsets.java Outdated
}

/** Gets the list of column qualifiers included in this authorized view. */
public ImmutableList<ByteString> getQualifiers() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the API to return List cause we don't want to leak guava dependencies:

public List<ByteString> getQualifiers() {
   return ImmutableList.copyOf(...);
}

...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/FamilySubsets.java Outdated
}

/** Gets the list of column qualifier prefixes included in this authorized view. */
public ImmutableList<ByteString> getQualifierPrefixes() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/SubsetView.java Outdated
}

/** Gets the row prefixes to be included in this subset view. */
public ImmutableList<ByteString> getRowPrefixes() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/SubsetView.java Outdated
}

/** Gets the map from familyId to familySubsets in this subset view. */
public ImmutableMap<String, FamilySubsets> getFamilySubsets() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/SubsetView.java Outdated
/** Adds a new familyId with its familySubsets to the subset view. */
public SubsetView addFamilySubsets(String familyId, FamilySubsets familySubsets) {
if (this.builder.containsFamilySubsets(familyId)) {
// If the familyId exists, append the familySubsets to the existing value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the default behavior be replacing instead of merging?

...d-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableAuthorizedViewIT.java Outdated
.setAuthorizedViewType(
SubsetView.create()
.addRowPrefix("row#")
.addFamilySubsets("cf1", FamilySubsets.create().addQualifier("qualifier"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we update the logic to replace, we probably also need to update this test

setFamilySubset instead of add and use List rather than ImmutableList
e28c385 
Change-Id: Ibdb2c8a62dc55c44059d5ec2296c57c7d430baa4
@mutianf mutianf added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@mutianf mutianf merged commit 13d1df3 into googleapis:main Mar 27, 2024
21 of 22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 27, 2024
@release-please release-please bot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trollyxia @mutianf @igorbernstein2 @kolea2 @yoshi-kokoro