Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add String type with Utf8Raw encoding to Bigtable API #2191

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat: Add String type with Utf8Raw encoding to Bigtable API #2191

merged 2 commits into from
Jun 25, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Mar 30, 2024 •
edited by igorbernstein2
Loading

  • Regenerate this pull request now.

Bigtable will allow users to configure the type of a column family with string type

PiperOrigin-RevId: 636631633

Source-Link: googleapis/googleapis@89a8364

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d7767007eae0fe87755b21cfe569b8779f02151c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDc3NjcwMDdlYWUwZmU4Nzc1NWIyMWNmZTU2OWI4Nzc5ZjAyMTUxYyJ9

BEGIN_NESTED_COMMIT
chore: update copyright year for auto-generated protos
PiperOrigin-RevId: 631538781

Source-Link: googleapis/googleapis@3597f7d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8021fdf8d66f6005519c044d5834124b677dc919
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0
PiperOrigin-RevId: 626430774

Source-Link: googleapis/googleapis@835b84e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/43f369d90f19d09ac18720151ab106042beb811b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNmMzY5ZDkwZjE5ZDA5YWMxODcyMDE1MWFiMTA2MDQyYmViODExYiJ9

build: Update protobuf to 25.3 in WORKSPACE

PiperOrigin-RevId: 624989428

Source-Link: googleapis/googleapis@caf600a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/cc580b8ea4c07f774093d0f8c4afedd2eae6e856
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2M1ODBiOGVhNGMwN2Y3NzQwOTNkMGY4YzRhZmVkZDJlYWU2ZTg1NiJ9

feat: publish Automated Backups protos

PiperOrigin-RevId: 620381983

Source-Link: googleapis/googleapis@a70aa2c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e3fb57f9dd4a10b6c20359ec92a72e87631991b8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNmYjU3ZjlkZDRhMTBiNmMyMDM1OWVjOTJhNzJlODc2MzE5OTFiOCJ9
END_NESTED_COMMIT

@dpebot
Copy link
Collaborator

dpebot commented Mar 30, 2024

/gcbrun

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 30, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review March 30, 2024 02:57
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners March 30, 2024 02:57
@dpebot
Copy link
Collaborator

dpebot commented Mar 30, 2024

/gcbrun

@gcf-owl-bot gcf-owl-bot bot changed the title feat: publish Automated Backups protos build: Update protobuf to 25.3 in WORKSPACE Apr 15, 2024
@dpebot
Copy link
Collaborator

dpebot commented Apr 15, 2024

/gcbrun

1 similar comment
@dpebot
Copy link
Collaborator

dpebot commented Apr 15, 2024

/gcbrun

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 15, 2024
@gcf-owl-bot gcf-owl-bot bot changed the title build: Update protobuf to 25.3 in WORKSPACE fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0 Apr 19, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Apr 19, 2024
@dpebot
Copy link
Collaborator

dpebot commented Apr 19, 2024

/gcbrun

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 19, 2024
@dpebot
Copy link
Collaborator

dpebot commented Apr 19, 2024

/gcbrun

1 similar comment
@dpebot
Copy link
Collaborator

dpebot commented Apr 22, 2024

/gcbrun

@gcf-owl-bot GCF Owl Bot
Copy link
Contributor Author

gcf-owl-bot bot commented Apr 22, 2024

Owl bot is regenerating pull request 2191...
Build name: ODFiYzcxYzgtZWVlOC00NDBmLTg4MzUtOTAwMjAxOTJjMzU0

@dpebot
Copy link
Collaborator

dpebot commented Apr 22, 2024

/gcbrun

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Apr 22, 2024
@dpebot
Copy link
Collaborator

dpebot commented Apr 22, 2024

/gcbrun

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 22, 2024
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 23, 2024
@dpebot
Copy link
Collaborator

dpebot commented May 23, 2024

/gcbrun

1 similar comment
@dpebot
Copy link
Collaborator

dpebot commented May 28, 2024

/gcbrun

@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2024
@lqiu96
Copy link
Contributor

lqiu96 commented May 28, 2024

@igorbernstein2 Thanks for taking a look. It took me a bit to try and refresh my memory of this.

IIRC, the core issue is that we don't have the serviceName value from the Enhanced version of the generated StubSettings. I believe the simplest solution is to copy the serviceName implementation into the EnhancedStubSettings. I've made that change locally to test in this PR and the CI passes. I've also updated the branch to include the latest Gax changes (which makes the StubSettings.Builder and StubSetting's implementation of getEndpoint() return the same value. This way we don't need build the Builder to get the resolved endpoint. This should allow BigTable to continue to pass the builder to patchCredentials(...).

The only manual change needed is to reimplement getServiceName(). But it does require adding introducing a handwritten public method.

@blakeli0 blakeli0 mentioned this pull request Jun 10, 2024
Merged
@gcf-owl-bot GCF Owl Bot
Copy link
Contributor Author

gcf-owl-bot bot commented Jun 11, 2024

Owl bot is regenerating pull request 2191...
Build name: ODMyMzM0YjItMzNjMi00NzI1LThmZDUtMTI2ZTk3MDk2Mjg5

@gcf-owl-bot
feat: Add String type with Utf8Raw encoding to Bigtable API
99fda11 
Bigtable will allow users to configure the type of a column family with string type

PiperOrigin-RevId: 636631633

Source-Link: googleapis/googleapis@89a8364

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d7767007eae0fe87755b21cfe569b8779f02151c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDc3NjcwMDdlYWUwZmU4Nzc1NWIyMWNmZTU2OWI4Nzc5ZjAyMTUxYyJ9

chore: update copyright year for auto-generated protos

PiperOrigin-RevId: 631538781

Source-Link: googleapis/googleapis@3597f7d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8021fdf8d66f6005519c044d5834124b677dc919
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9

fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0

PiperOrigin-RevId: 626430774

Source-Link: googleapis/googleapis@835b84e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/43f369d90f19d09ac18720151ab106042beb811b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNmMzY5ZDkwZjE5ZDA5YWMxODcyMDE1MWFiMTA2MDQyYmViODExYiJ9

build: Update protobuf to 25.3 in WORKSPACE

PiperOrigin-RevId: 624989428

Source-Link: googleapis/googleapis@caf600a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/cc580b8ea4c07f774093d0f8c4afedd2eae6e856
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2M1ODBiOGVhNGMwN2Y3NzQwOTNkMGY4YzRhZmVkZDJlYWU2ZTg1NiJ9

feat: publish Automated Backups protos

PiperOrigin-RevId: 620381983

Source-Link: googleapis/googleapis@a70aa2c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e3fb57f9dd4a10b6c20359ec92a72e87631991b8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNmYjU3ZjlkZDRhMTBiNmMyMDM1OWVjOTJhNzJlODc2MzE5OTFiOCJ9
@dpebot
Copy link
Collaborator

dpebot commented Jun 11, 2024

/gcbrun

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Jun 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@dpebot
Copy link
Collaborator

dpebot commented Jun 11, 2024

/gcbrun

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jun 11, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 25, 2024
@gcf-owl-bot GCF Owl Bot
Copy link
Contributor Author

gcf-owl-bot bot commented Jun 25, 2024

Owl bot is regenerating pull request 2191...
Build name: MzYwMjI3MWYtODNlZC00YTZhLWJhZWEtMzkzMDk2ZWJiZWVh

@igorbernstein2 igorbernstein2 merged commit e7f03fc into main Jun 25, 2024
22 of 24 checks passed
@igorbernstein2 igorbernstein2 deleted the owl-bot-copy branch June 25, 2024 14:19
@release-please release-please bot mentioned this pull request Jun 25, 2024
Merged
ron-gal pushed a commit to ron-gal/java-bigtable that referenced this pull request Jul 23, 2024
@gcf-owl-bot @ron-gal
feat: Add String type with Utf8Raw encoding to Bigtable API (googleap…
8054a5b 
…is#2191)

* feat: Add String type with Utf8Raw encoding to Bigtable API

Bigtable will allow users to configure the type of a column family with string type

PiperOrigin-RevId: 636631633

Source-Link: googleapis/googleapis@89a8364

Source-Link: googleapis/googleapis-gen@d776700
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDc3NjcwMDdlYWUwZmU4Nzc1NWIyMWNmZTU2OWI4Nzc5ZjAyMTUxYyJ9

chore: update copyright year for auto-generated protos

PiperOrigin-RevId: 631538781

Source-Link: googleapis/googleapis@3597f7d

Source-Link: googleapis/googleapis-gen@8021fdf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9

fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0

PiperOrigin-RevId: 626430774

Source-Link: googleapis/googleapis@835b84e

Source-Link: googleapis/googleapis-gen@43f369d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNmMzY5ZDkwZjE5ZDA5YWMxODcyMDE1MWFiMTA2MDQyYmViODExYiJ9

build: Update protobuf to 25.3 in WORKSPACE

PiperOrigin-RevId: 624989428

Source-Link: googleapis/googleapis@caf600a

Source-Link: googleapis/googleapis-gen@cc580b8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2M1ODBiOGVhNGMwN2Y3NzQwOTNkMGY4YzRhZmVkZDJlYWU2ZTg1NiJ9

feat: publish Automated Backups protos

PiperOrigin-RevId: 620381983

Source-Link: googleapis/googleapis@a70aa2c

Source-Link: googleapis/googleapis-gen@e3fb57f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNmYjU3ZjlkZDRhMTBiNmMyMDM1OWVjOTJhNzJlODc2MzE5OTFiOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Jul 26, 2024
@gcf-owl-bot @lqiu96
feat: Add String type with Utf8Raw encoding to Bigtable API (#2191)
109e4de 
* feat: Add String type with Utf8Raw encoding to Bigtable API

Bigtable will allow users to configure the type of a column family with string type

PiperOrigin-RevId: 636631633

Source-Link: googleapis/googleapis@89a8364

Source-Link: googleapis/googleapis-gen@d776700
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDc3NjcwMDdlYWUwZmU4Nzc1NWIyMWNmZTU2OWI4Nzc5ZjAyMTUxYyJ9

chore: update copyright year for auto-generated protos

PiperOrigin-RevId: 631538781

Source-Link: googleapis/googleapis@3597f7d

Source-Link: googleapis/googleapis-gen@8021fdf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9

fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0

PiperOrigin-RevId: 626430774

Source-Link: googleapis/googleapis@835b84e

Source-Link: googleapis/googleapis-gen@43f369d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNmMzY5ZDkwZjE5ZDA5YWMxODcyMDE1MWFiMTA2MDQyYmViODExYiJ9

build: Update protobuf to 25.3 in WORKSPACE

PiperOrigin-RevId: 624989428

Source-Link: googleapis/googleapis@caf600a

Source-Link: googleapis/googleapis-gen@cc580b8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2M1ODBiOGVhNGMwN2Y3NzQwOTNkMGY4YzRhZmVkZDJlYWU2ZTg1NiJ9

feat: publish Automated Backups protos

PiperOrigin-RevId: 620381983

Source-Link: googleapis/googleapis@a70aa2c

Source-Link: googleapis/googleapis-gen@e3fb57f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNmYjU3ZjlkZDRhMTBiNmMyMDM1OWVjOTJhNzJlODc2MzE5OTFiOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpebot @lqiu96 @igorbernstein2 @yoshi-kokoro @kolea2