Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry INTERNAL retriable auth errors #2239

Merged
merged 4 commits into from
May 21, 2024
Merged

fix: retry INTERNAL retriable auth errors #2239

merged 4 commits into from
May 21, 2024

Conversation

igorbernstein2
Copy link
Contributor

Change-Id: I3939a89d40ecd4304bccaf0340fe169d6a083712

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
fix: retry INTERNAL retriable auth errors
b563dfe 
Change-Id: I3939a89d40ecd4304bccaf0340fe169d6a083712
@igorbernstein2 igorbernstein2 requested review from a team as code owners May 21, 2024 10:56
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels May 21, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner May 21, 2024 11:01
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
rameshdharan
rameshdharan approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@rameshdharan rameshdharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me sad, but looks like it will achieve the intended effect.

@igorbernstein2 igorbernstein2 merged commit 4cdb6da into main May 21, 2024
22 of 23 checks passed
@igorbernstein2 igorbernstein2 deleted the retry-auth branch May 21, 2024 11:55
@release-please release-please bot mentioned this pull request May 21, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request May 21, 2024
@release-please
chore(main): release 2.39.3 (#2240)
69dd8fa 
🤖 I have created a release *beep* *boop*
---


## [2.39.3](https://togithub.com/googleapis/java-bigtable/compare/v2.39.2...v2.39.3) (2024-05-21)


### Bug Fixes

* Retry INTERNAL retriable auth errors ([#2239](https://togithub.com/googleapis/java-bigtable/issues/2239)) ([4cdb6da](https://togithub.com/googleapis/java-bigtable/commit/4cdb6da8920cd3346a9d79d67432cef588d93bb0))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rameshdharan rameshdharan rameshdharan approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorbernstein2 @rameshdharan