Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix emulator command arg data-dir #1695

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Conversation

cindy-peng
Copy link
Contributor

The current gcloudRunner doesn't take any --data-dir flag due to a bug. This PR is to fix the --data-dir flag.

@cindy-peng cindy-peng requested review from a team as code owners January 2, 2025 20:29
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/java-datastore API. labels Jan 2, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jan 2, 2025
Copy link

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ArrayValue.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ArrayValueOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CompositeFilter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CompositeFilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/DatastoreProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Entity.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityResult.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityResultOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Filter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/FilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQuery.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryParameter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryParameterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Key.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KeyOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KindExpression.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KindExpressionOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Mutation.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationResult.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationResultOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PartitionId.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PartitionIdOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Projection.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ProjectionOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyFilter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyFilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyOrder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyOrderOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyReference.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyReferenceOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Query.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryResultBatch.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryResultBatchOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReadOptions.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReadOptionsOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/TransactionOptions.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/TransactionOptionsOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Value.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ValueOrBuilder.java

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Jan 4, 2025
@cindy-peng cindy-peng added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 4, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9d53195 into main Jan 4, 2025
22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 4, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the cindy/fixemulator branch January 4, 2025 02:16
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jan 13, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`6.84.0` -> `6.85.0` |
|
[com.google.apis:google-api-services-cloudkms](http://nexus.sonatype.org/oss-repository-hosting.html)
([source](http://svn.sonatype.org/spice/tags/oss-parent-7)) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`v1-rev20241111-2.0.0` -> `v1-rev20250102-2.0.0` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.25.1` -> `2.25.2` |
|
[com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin)
| plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.6.1` ->
`2.7.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.49` -> `2.29.50` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.49` -> `2.29.50` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.49` -> `2.29.50` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.49` -> `2.29.50` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.49` -> `2.29.50` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.49` -> `2.29.50` |

---

### Release Notes

<details>
<summary>googleapis/java-spanner
(com.google.cloud:google-cloud-spanner)</summary>

###
[`v6.85.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6850-2025-01-10)

##### Features

- Add gcp client attributes in OpenTelemetry traces
([#&#8203;3595](googleapis/java-spanner#3595))
([7893f24](googleapis/java-spanner@7893f24))
- Add LockHint feature
([#&#8203;3588](googleapis/java-spanner#3588))
([326442b](googleapis/java-spanner@326442b))
- **spanner:** MTLS setup for spanner external host clients
([#&#8203;3574](googleapis/java-spanner#3574))
([f8dd152](googleapis/java-spanner@f8dd152))

##### Dependencies

- Update dependency com.google.api.grpc:proto-google-cloud-monitoring-v3
to v3.56.0
([#&#8203;3563](googleapis/java-spanner#3563))
([e4d0b0f](googleapis/java-spanner@e4d0b0f))
- Update dependency com.google.api.grpc:proto-google-cloud-monitoring-v3
to v3.57.0
([#&#8203;3592](googleapis/java-spanner#3592))
([a7542da](googleapis/java-spanner@a7542da))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.41.1
([#&#8203;3589](googleapis/java-spanner#3589))
([2cd4238](googleapis/java-spanner@2cd4238))
- Update dependency com.google.cloud.opentelemetry:exporter-trace to
v0.33.0
([#&#8203;3455](googleapis/java-spanner#3455))
([70649dc](googleapis/java-spanner@70649dc))
- Update dependency com.google.re2j:re2j to v1.8
([#&#8203;3594](googleapis/java-spanner#3594))
([0f2013d](googleapis/java-spanner@0f2013d))
- Update googleapis/sdk-platform-java action to v2.51.1
([#&#8203;3591](googleapis/java-spanner#3591))
([3daa1a0](googleapis/java-spanner@3daa1a0))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.25.2`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2252-2025-01-09)

##### Bug Fixes

- **deps:** Update the Java code generator (gapic-generator-java) to
2.51.1
([90d8b30](googleapis/java-datastore@90d8b30))
- Fix emulator command arg data-dir
([#&#8203;1695](googleapis/java-datastore#1695))
([9d53195](googleapis/java-datastore@9d53195))

##### Dependencies

- Update dependency com.google.cloud:gapic-libraries-bom to v1.49.0
([#&#8203;1693](googleapis/java-datastore#1693))
([8160c28](googleapis/java-datastore@8160c28))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.41.1
([#&#8203;1703](googleapis/java-datastore#1703))
([bf9537f](googleapis/java-datastore@bf9537f))
- Update dependency com.google.guava:guava-testlib to v33.4.0-jre
([#&#8203;1694](googleapis/java-datastore#1694))
([b91a2af](googleapis/java-datastore@b91a2af))

</details>

<details>
<summary>autonomousapps/dependency-analysis-android-gradle-plugin
(com.autonomousapps.dependency-analysis)</summary>

###
[`v2.7.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-270)

-   \[Feat]: can set severity and filter duplicate class warnings.
- \[Feat]: don't recommend removing implementation dependency on
necessary superclass.
-   \[Chore]: use non-deprecated method when available.
-   \[Chore]: update various dependencies, including antlr.

New DSL option for configuring duplicate class warnings:

```groovy
// root build.gradle[.kts]
dependencyAnalysis {
  issues {
    all {
      onDuplicateClassWarnings {
        severity(<"fail"|"warn"|"ignore">)
        // Fully-qualified class reference to exclude, slash- or dot-delimited
        exclude("org/jetbrains/annotations/NotNull", "org.jetbrains.annotations.Nullable")
      }
    }
  }
}
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: c370d05a3d2bb5c849f728746c58480ba5faf607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants