Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error messages in tests #1855

Merged
merged 5 commits into from
Nov 1, 2024
Merged

fix: Improve error messages in tests #1855

merged 5 commits into from
Nov 1, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Sep 30, 2024

WatchTest.jaca intermittently fails when requests is not empty.

To gain more information when this happens, the assertion now does a comparison with an empty array. That way, when requests is not empty, the error message will contain the contents of requests.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 30, 2024
Copy link

conventional-commit-lint-gcf bot commented Sep 30, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Sep 30, 2024
@tom-andersen tom-andersen changed the title Fix CI fix: Improve error messages in tests Sep 30, 2024
@tom-andersen tom-andersen marked this pull request as ready for review September 30, 2024 17:12
@tom-andersen tom-andersen requested review from a team as code owners September 30, 2024 17:12
@tom-andersen tom-andersen requested a review from wu-hui September 30, 2024 17:13
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2024
@tom-andersen tom-andersen merged commit cb5f9d6 into main Nov 1, 2024
23 of 24 checks passed
@tom-andersen tom-andersen deleted the tomandersen/fixCI branch November 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants