Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

deps: using shared deps for iam proto dependency version #387

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Mar 9, 2022

Fixing the dependency convergence problem of googleapis/java-cloud-bom#3917 (comment) . Somehow in this commit, java-security-private-ca is declaring its own version of iam proto versions, rather than relying on the shared dependencies BOM.

https://github.com/googleapis/java-shared-dependencies/blob/main/first-party-dependencies/pom.xml#L161 is where the shared dependencies BOM declares its iam proto version.


Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@suztomo suztomo requested a review from a team as a code owner March 9, 2022 20:17
@product-auto-label product-auto-label bot added the api: security-privateca Issues related to the googleapis/java-security-private-ca API. label Mar 9, 2022
@suztomo suztomo requested review from Neenu1995 and meltsufin March 9, 2022 20:20
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 9, 2022
@suztomo suztomo merged commit dbb82c6 into googleapis:main Mar 9, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 10, 2022
🤖 I have created a release *beep* *boop*
---


### [2.2.5](v2.2.4...v2.2.5) (2022-03-09)


### Dependencies

* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.8 ([#385](#385)) ([02702ba](02702ba))
* using shared deps for iam proto dependency version ([#387](#387)) ([dbb82c6](dbb82c6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: security-privateca Issues related to the googleapis/java-security-private-ca API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants