Feat: Updates colspec to account for sqlalchemy Enum #1111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flakybot was flagging a number of tests that failed when handling sqlalchemy Enums. In consultation with members of the sqlalchemy team, it was suggested to follow an approach similar to the one used by sqlite: To modify the colspec.
The backstory is this:
We made a class (
BQString
) that inherits from sqlalchemy'sString
.BQString
has one function (and only one).It will process string literals to replace single percents with double percents.
Where the issue comes into play is this:
Fixes #1102 🦕
Fixes #1103 🦕
Fixes #1104 🦕
Fixes #1105 🦕
Fixes #1106 🦕
Fixes #1107 🦕
Fixes #1108 🦕