feat: add ExternalCatalogTableOptions class and tests #2116
+367
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
tswast
changed the title
tswast
approved these changes
Jan 17, 2025
chalmerlowe
deleted the
feat-b358215039-add-externalcatalogtableoptions-class
branch
chalmerlowe
added a commit
that referenced
this pull request
Jan 22, 2025
* Updates most of external_catalog_table_options * Adds ExternalCatalogTableOptions and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ExternalCatalogTableOptions class and the associated tests, plus minor tweaks to support both of those changes.
IN ADDITION, mypy was balking on an issue in magics, so a minor tweak to ignore the type of an object that comes from IPython was added.