-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: add migration helpers and guide for breaking changes #960
Comments
@plamut Does this make sense? I want to keep the changes we've made and avoid using/updating the |
How is that supposed to work, just keeping those type classes around so that one can import them if really needed? But otherwise no compatibility logic and no direct exposure in the top level namespace Re: conversions - we'll probably recommend With these assumptions, I think it could work fine with minimal overhead, yes. As a bonus, we could also issue a runtime warning if anything is imported from the Edit: Will we also keep the v2 type classes in the reference docs? Noticed this aspect when resolving a merge conflict on the v2 removal PR. |
That's right. Just keep the autogenerated classes around and show folks how to parse JSON. Probably with a code sample for what we used to do that ignored unknown enums and such, especially since we don't plan to keep the type classes updated.
That's a great idea.
Yes, let's keep them in the docs and add a deprecation warning. |
Looking at #855 and how large it is, it IMO makes sense to do this in a separate PR after that large PR has been merged. |
I'd like to make sure we don't get folks stuck on v2. I know we have some internal (Google) customers who rely on the BQML stats protobuf messages (the ones in
google.cloud.bigquery_v2
.I propose
google.cloud.bigquery_v2
, but document that they are deprecated and are not updated.UPGRADING
guide how to manually convert from the dictionaries to the classes ingoogle.cloud.bigquery_v2
with some code samples.Regarding the pandas connector changes, we should also document those in the
UPGRADING
guide, ideally with code samples on how to get / convert to the old dtypes if desired.The text was updated successfully, but these errors were encountered: