-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: named database support #439
Conversation
* feat: Add named database support * test: Use named db in system tests
I've updated these PRs and got the tests green. Seeking a go ahead for merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nits and pending approval from @googleapis/yoshi-python
Wait for #436 |
* Feat: Parametrize the tests for multidb support Remove "database" argument from Query and AggregationQuery constructors. Use the "database" from the client instead. Once set in the client, the "database" will be used throughout and cannot be re-set. Parametrize the tests where-ever clients are used. Use the `system-tests-named-db` in the system test. * Add test case for when parent database name != child database name * Update owlbot, removing the named db parameter * Reverted test fixes * fixing tests * fix code coverage * pr suggestion * address pr comments --------- Co-authored-by: Vishwaraj Anand <[email protected]>
@Mariatta - how sure are we on regression here? (Support case now open)
|
Hi @smittysmee, Please could you file a bug with sample code? Please include the versions of |
@parthea - it was a lack of backwards compatibility in a rollover and cache.
Entity A did not update with latest key structure containing added attribute |
@smittysmee by cache hit, it suggests to me that the issue is local to your environment? Pls confirm if that was not the case. |
The branch
multi-db
was outdated. This PR makes it up to date withmain
and contains the commit from #398.We will create the multi db test parametrization PR (#436) branch against this branch instead of
main
.Once the feature is out of preview, we should:
main
.