Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

chore: add generation of pb2 files via owlbot/bazel #124

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 27, 2024

This PR is built on top of #122 and #123. This PR requires changes to build rules in googleapis/googleapis. I'll mark this PR as ready for review once the changes to the build rules are live.

I tested the changes locally using the commands below and the results are in #125.

In a clone of googleapis/googleapis, run

gbazelisk build //google/iam/v1/logging:audit-data-py
gbazelisk build //google/iam/v1:iam-v1-py

The in a clone of this repo, run

docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v <path to your bazel-bin>:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --source-dir /bazel-bin --dest /repo

and

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

@parthea parthea requested a review from a team as a code owner December 27, 2024 20:42
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: iam Issues related to the googleapis/python-grpc-google-iam-v1 API. labels Dec 27, 2024
@parthea parthea marked this pull request as draft December 27, 2024 20:44
@parthea parthea mentioned this pull request Dec 27, 2024
@parthea
Copy link
Contributor Author

parthea commented Dec 27, 2024

Wait for cl/710118578

@parthea parthea marked this pull request as ready for review January 2, 2025 20:15
Base automatically changed from remove-proto-files to main January 9, 2025 20:38
@parthea parthea merged commit a8cb675 into main Jan 9, 2025
16 checks passed
@parthea parthea deleted the add-generation-via-bazel-owlbot branch January 9, 2025 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: iam Issues related to the googleapis/python-grpc-google-iam-v1 API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants