From 0b8f5b0262193e220e66d6ae0e15e7f616b5b1bb Mon Sep 17 00:00:00 2001 From: cojenco Date: Wed, 28 Feb 2024 13:25:37 -0800 Subject: [PATCH] samples: replace deprecated method (#1211) * samples: replace deprecated method * update print statement, decode --- samples/snippets/snippets_test.py | 4 ++-- samples/snippets/storage_download_into_memory.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/samples/snippets/snippets_test.py b/samples/snippets/snippets_test.py index 7add15184..ff1d23005 100644 --- a/samples/snippets/snippets_test.py +++ b/samples/snippets/snippets_test.py @@ -361,7 +361,7 @@ def test_generate_upload_signed_url_v4(test_bucket, capsys): bucket = storage.Client().bucket(test_bucket.name) blob = bucket.blob(blob_name) - assert blob.download_as_string() == content + assert blob.download_as_bytes() == content def test_generate_signed_policy_v4(test_bucket, capsys): @@ -592,7 +592,7 @@ def test_storage_compose_file(test_bucket): source_files[1], dest_file.name, ) - composed = destination.download_as_string() + composed = destination.download_as_bytes() assert composed.decode("utf-8") == source_files[0] + source_files[1] diff --git a/samples/snippets/storage_download_into_memory.py b/samples/snippets/storage_download_into_memory.py index 453a13e21..97f677054 100644 --- a/samples/snippets/storage_download_into_memory.py +++ b/samples/snippets/storage_download_into_memory.py @@ -37,11 +37,11 @@ def download_blob_into_memory(bucket_name, blob_name): # any content from Google Cloud Storage. As we don't need additional data, # using `Bucket.blob` is preferred here. blob = bucket.blob(blob_name) - contents = blob.download_as_string() + contents = blob.download_as_bytes() print( - "Downloaded storage object {} from bucket {} as the following string: {}.".format( - blob_name, bucket_name, contents + "Downloaded storage object {} from bucket {} as the following bytes object: {}.".format( + blob_name, bucket_name, contents.decode("utf-8") ) )