Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trusted-contributions-gcf]: consider adding a /gcbrun comment #1678

Closed
coryan opened this issue Apr 24, 2021 · 1 comment · Fixed by #1682
Closed

[trusted-contributions-gcf]: consider adding a /gcbrun comment #1678

coryan opened this issue Apr 24, 2021 · 1 comment · Fixed by #1682
Assignees
Labels
bot: trusted contributor type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link

coryan commented Apr 24, 2021

Is your feature request related to a problem? Please describe.

When renovatebot creates a PR I have to manually start the GCB (Google Cloud Build) builds, while the Kokoro builds start automatically.

Describe the solution you'd like

The trusted-contributions-gcf bot needs to insert a comment saying /gcbrun.

Describe alternatives you've considered

AFAIK this is it, there is no other way to trigger GCB builds, but I would be happy to hear otherwise.

Additional context

This could be a good example:

googleapis/google-cloud-cpp#6357

/cc: @devjgm in case he has a better idea.

@devjgm
Copy link

devjgm commented Apr 25, 2021

It may be possible to have our google-cloud-cpp-bot detect that a PR is coming from renovatebot and then add a /gcbrun comment. Not sure if that's secure enough though.

I don't know what trusted-contributions-gcf is or if that's a better idea.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 26, 2021
@JustinBeckwith JustinBeckwith added bot: trusted contributor type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 26, 2021
@JustinBeckwith JustinBeckwith self-assigned this Apr 26, 2021
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: trusted contributor type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants