Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owlbot: make OwlBot required check on Java repositories #2112

Closed
bcoe opened this issue Jun 18, 2021 · 3 comments
Closed

owlbot: make OwlBot required check on Java repositories #2112

bcoe opened this issue Jun 18, 2021 · 3 comments
Assignees
Labels
bot: owl-bot type: process A process-related concern. May include testing, release, or the like.

Comments

@bcoe
Copy link
Contributor

bcoe commented Jun 18, 2021

If OwlBot doesn't run on a pull request, it can result in a bad merge to the main branch, e.g., merging the staging directory.

OwlBot should be made a required check for languages that are using OwlBot. If OwlBot ever fails to run:

  • we would be grateful if you'd notify the GitHub automation chat immediately (if we can catch OwlBot in the act of not running, we might be able to pin down an edge case that you're bumping into).
  • after we've made an effort to diagnose the issue, add the owlbot:run label to your PR to manually run OwlBot.

Refs: #1714

@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 18, 2021
@chingor13 chingor13 added type: process A process-related concern. May include testing, release, or the like. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 20, 2021
@chingor13
Copy link
Contributor

Changed to process. We are working on completing the migration

@chingor13
Copy link
Contributor

Migration is complete, we should be able to make it a required check

@chingor13
Copy link
Contributor

@Neenu1995 already made most of the Java repos require this check and will convert any stragglers as they are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: owl-bot type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants