-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report(topbar): fix overflowing url #9497
Conversation
Hello Lighthouse reviewers! I heard there might be a way to truncate from the middle, but I couldn't find the utility. The screenshot above shows truncation from the right, which I think looks okay. What do others think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks very much @psybuzz!
@connorjclark was this the method you had in mind for fixing it?
yup this is perfect. |
Thanks for the reviews! I'm not authorized to merge this PR, so feel free to merge it at will. |
It is line break/word wrap related so I feel like we at least have to give @paulirish a chance if he wants since it's almost as if those CSS properties have declared war on us 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking this, though has someone double checked how this works/looks in DevTools, where the bug originated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll pile onto the LGTM 🚂
Perhaps @psybuzz could try that out. I could too, would just take awhile to build Chromium away from my desktop. @psybuzz: basically you just build everything ( Alternatively, these changes seem benign enough to assume they'll work in DevTools (pending "jinx"...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iz good.
Thanks everyone! |
This modifies UI in the topbar to
Screenshot: https://imgur.com/a/2DQ5RmV
Issue: #9142
Associated Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=971585