a11y: rewrite td-headers-attr titles #9587
Conversation
exterkamp
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
exterkamp
changed the title
Co-Authored-By: Patrick Hulce <[email protected]>
There was a problem hiding this comment.
TIL [headers] attribute.
TIL axe's docs on this audit are mostly about scope which the audit doesnt care about. dequelabs/axe-core#1782
our docs on it are also a bit confusing because it uses header but the example is seemingly incorrect not because it Week isn't an [id] in the table but because "one column has multiple table headers".
plus i bet this attribute doesn't get much use anyhow.
bleh.
| @@ -276,10 +276,10 @@ | |||
| "message": "Screen readers have features to make navigating tables easier. Ensuring `<td>` cells using the `[headers]` attribute only refer to other cells in the same table may improve the experience for screen reader users. [Learn more](https://web.dev/td-headers-attr/)." | |||
| }, | |||
| "lighthouse-core/audits/accessibility/td-headers-attr.js | failureTitle": { | |||
| "message": "Cells in a `<table>` element that use the `[headers]` attribute do not refer to headers of the same table." | |||
| "message": "Cells in a `<table>` element that use the `[headers]` attribute refer to element `id`s not found within the same table." | |||
There was a problem hiding this comment.
@exterkamp is the plurliazation of a placeholder not a problem then? I noticed you did it in #9590 too
There was a problem hiding this comment.
Shouldn't be, it's only a problem when we have a variable amount of things. If we passed in a variable like idCount and needed a variable amount of ids then it would be a problem.
There was a problem hiding this comment.
Shouldn't be, it's only a problem when we have a variable amount of things. If we passed in a variable like
idCountand needed a variable amount ofids then it would be a problem.
but is there a single character (or equivalent characters) in other languages that means "make the attached word plural"?
Seems better to reword, even if it gets into plural awkwardness (and even better if we can reword to avoid the awkwardness) "refer to an element id not found within the same table" or whatever
There was a problem hiding this comment.
ya brendan much better worded my concern :) 👍
Summary
Translators were confused by these titles, and looking into it, they don't seem to make sense. This should be more accurate to the audit itself.
Deque Link