Flaky: Race condition in TestControllerSyncGameServerStartingState (#779

)
googleforgames · May 21, 2019 · 6b4698d · 6b4698d
1 parent a9c867f
commit 6b4698d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pkg/gameservers/controller.go b/pkg/gameservers/controller.go
@@ -76,9 +76,8 @@ type Controller struct {
 	workerqueue            *workerqueue.WorkerQueue
 	creationWorkerQueue    *workerqueue.WorkerQueue // handles creation only
 	deletionWorkerQueue    *workerqueue.WorkerQueue // handles deletion only
-	stop                   <-chan struct {
-	}
-	recorder record.EventRecorder
+	stop                   <-chan struct{}
+	recorder               record.EventRecorder
 }
 
 // NewController returns a new gameserver crd controller

diff --git a/pkg/gameservers/controller_test.go b/pkg/gameservers/controller_test.go
@@ -757,7 +757,7 @@ func TestControllerSyncGameServerStartingState(t *testing.T) {
 			return true, gs, nil
 		})
 
-		_, cancel := agtesting.StartInformers(m, c.gameServerSynced)
+		_, cancel := agtesting.StartInformers(m, c.gameServerSynced, c.podSynced, c.nodeSynced)
 		defer cancel()
 
 		gs, err := c.syncGameServerStartingState(gsFixture)